linux-kernel - Re: [PATCH v7 1/2] PCI: iproc: Retry request when CRS returned from EP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb01a01b-ee8a-1c51-69ba-838bfe94b6f6@codeaurora.org>
Date:   Wed, 23 Aug 2017 11:52:40 -0400
From:   Sinan Kaya <okaya@...eaurora.org>
To:     Oza Oza <oza.oza@...adcom.com>, Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Jon Mason <jonmason@...adcom.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        Andy Gospodarek <gospo@...adcom.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Oza Pawandeep <oza.pawandeep@...il.com>,
        Timur Tabi <timur@...eaurora.org>,
        Alex Williamson <alex.williamson@...hat.com>
Subject: Re: [PATCH v7 1/2] PCI: iproc: Retry request when CRS returned from
 EP

Hi Oza,

> In working Enumuration case I get following:
> [    9.125976] pci 0000:00:00.0: bridge configuration invalid ([bus
> 00-00]), re-configuring
> [    9.134267] where=0x0 val=0xffff0001
> [    9.146946] where=0x0 val=0xffff0001
> [    9.158943] where=0x0 val=0xffff0001
> [    9.170945] where=0x0 val=0xffff0001
> [    9.186945] where=0x0 val=0xffff0001
> [    9.210944] where=0x0 val=0xffff0001
> [    9.250943] where=0x0 val=0xffff0001
> [    9.322942] where=0x0 val=0xffff0001
> [    9.458943] where=0x0 val=0xffff0001
> [    9.726942] where=0x0 val=0x9538086    >> actual vendor and device id.
> 
> so I think I have to retry in RC driver, so the old code still holds good.
> except that I have to do factoring out
You need to return 0xFFFF0001 for vendor ID register and return 0xFFFFFFFF for
other registers like COMMAND register during the CRS period.

> 
> please let me know If I missed anything, or you want me to try anything else.

Sinan