linux-kernel - [PATCH][pci-next] PCI: endpoint: fix incorrect end of table check in while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170823160303.23366-1-colin.king@canonical.com>
Date:   Wed, 23 Aug 2017 17:03:03 +0100
From:   Colin King <colin.king@...onical.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table check in while loop

From: Colin Ian King <colin.king@...onical.com>

Currently, the while loop will iterate until a matching name is found
or until the id pointer wraps around to NULL (the latter is incorrect).

The end of a pci_epf_device_id table is terminated with zero'd entries
for name and driver_data, so can change the while loop to iterate while
the first character in the name is a non-zero character.

Detected by CoverityScan, CID#1454557 ("Logically dead code")

Fixes: 9e9d6eb48623 ("PCI: endpoint: Add an API to get matching "pci_epf_device_id")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/pci/endpoint/pci-epf-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
index ae6fac5995e3..70eccc04ee7f 100644
--- a/drivers/pci/endpoint/pci-epf-core.c
+++ b/drivers/pci/endpoint/pci-epf-core.c
@@ -273,7 +273,7 @@ pci_epf_match_device(const struct pci_epf_device_id *id, struct pci_epf *epf)
 	if (!id || !epf)
 		return NULL;
 
-	while (id) {
+	while (*id->name) {
 		if (strcmp(epf->name, id->name) == 0)
 			return id;
 		id++;
-- 
2.14.1