linux-kernel - Re: [PATCH] x86/nmi/64: avoid passing user space rsp of pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK4g67bz=5Hy4jzAvp7nQpv++Bbzc90fFaXANdCmHycN9ReTxQ@mail.gmail.com>
Date:   Thu, 24 Aug 2017 01:34:39 +0800
From:   oliver yang <yangoliver@...il.com>
To:     Andy Lutomirski <luto@...capital.net>
Cc:     Josh Poimboeuf <jpoimboe@...hat.com>,
        yang oliver <yang_oliver@...mail.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "luto@...nel.org" <luto@...nel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/nmi/64: avoid passing user space rsp of pt_regs to
 nmi handler

2017-08-24 0:51 GMT+08:00 Andy Lutomirski <luto@...capital.net>:
> To avoid further wasting time solving this wrong: NAK.  pt_regs is the actual interrupted state, not some oddly sanitized version thereof.  NMI isn't even the only way you can have a weird pt_regs like this.
>
> It seems that some older kernels contain bugs where they incorrectly assume that regs->rsp is a valid pointer.  Why don't you write a patch for *that * and send it to lkml, us, and stable@...r.kernel.org.

Got it. Thanks for clear answer.

I agree that pt_regs users should handle it, if the pt_regs reflects
the actual interrupted status.


-- 
------------------
Oliver Yang