linux-kernel - Re: [PATCH] mm: swap: make free_swap_and_cache()/swapcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170823182750.GB4835@redhat.com>
Date:   Wed, 23 Aug 2017 14:27:50 -0400
From:   Jerome Glisse <jglisse@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Huang Ying <ying.huang@...el.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: swap: make free_swap_and_cache()/swapcache_prepare()
 inline functions

On Wed, Aug 23, 2017 at 03:31:42PM +0200, Arnd Bergmann wrote:
> We get a build warning from a boolean expression that is never used:
> 
> mm/madvise.c: In function 'madvise_free_pte_range':
> include/linux/swap.h:490:55: error: value computed is not used [-Werror=unused-value]
>  #define free_swap_and_cache(e) (is_migration_entry(e) || is_device_private_entry(e))
>                                                        ^~
> mm/madvise.c:353:4: note: in expansion of macro 'free_swap_and_cache'
>     free_swap_and_cache(entry);
> 
> This changes the two macros to a compound expression that gcc does
> not warn about. Changing them to inline functions would have been
> nicer but is not possible here because that would introduce a recursive
> header file dependency.
> 
> Fixes: mmotm ("mm/ZONE_DEVICE: new type of ZONE_DEVICE for unaddressable memory")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for taking care of that.

Reviewed-by: Jérôme Glisse <jglisse@...hat.com>