linux-kernel - Re: [PATCH V2] acpi: apei: clear error status before acknowledging the error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b5fb362-c184-7dde-ca0a-b6f0842fec63@codeaurora.org>
Date:   Wed, 23 Aug 2017 14:55:09 -0600
From:   "Baicar, Tyler" <tbaicar@...eaurora.org>
To:     rjw@...ysocki.net, lenb@...nel.org, will.deacon@....com,
        james.morse@....com, bp@...e.de, shiju.jose@...wei.com,
        geliangtang@...il.com, andriy.shevchenko@...ux.intel.com,
        tony.luck@...el.com, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, austinwc@...eaurora.org
Subject: Re: [PATCH V2] acpi: apei: clear error status before acknowledging
 the error

Hello Boris,

And input on this patch?

Thanks,
Tyler

On 8/3/2017 4:12 PM, Tyler Baicar wrote:
> Currently we acknowledge errors before clearing the error status.
> This could cause a new error to be populated by firmware in-between
> the error acknowledgment and the error status clearing which would
> cause the second error's status to be cleared without being handled.
> So, clear the error status before acknowledging the errors.
>
> Also, make sure to acknowledge the error if the error status read
> fails.
>
> V2: Only send error ack if there was an error populated
>      Remove curly braces that are no longer needed
>
> Signed-off-by: Tyler Baicar <tbaicar@...eaurora.org>
> ---
>   drivers/acpi/apei/ghes.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index d661d45..cda4a4f 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -743,17 +743,14 @@ static int ghes_proc(struct ghes *ghes)
>   	}
>   	ghes_do_proc(ghes, ghes->estatus);
>   
> +out:
> +	ghes_clear_estatus(ghes);
>   	/*
>   	 * GHESv2 type HEST entries introduce support for error acknowledgment,
>   	 * so only acknowledge the error if this support is present.
>   	 */
> -	if (is_hest_type_generic_v2(ghes)) {
> +	if (is_hest_type_generic_v2(ghes) && rc != -ENOENT)
>   		rc = ghes_ack_error(ghes->generic_v2);
> -		if (rc)
> -			return rc;
> -	}
> -out:
> -	ghes_clear_estatus(ghes);
>   	return rc;
>   }
>   

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.