linux-kernel - Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170823224752.p3ebgenlnstkd5jg@sirena.org.uk>
Date:   Wed, 23 Aug 2017 23:47:52 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Tom Rini <trini@...sulko.com>
Cc:     linux-kernel@...r.kernel.org, Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

On Wed, Aug 23, 2017 at 06:35:24PM -0400, Tom Rini wrote:

> After looking at 89128534f925 (which introduced the above line, and thus

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

> support for the Chromebook), I think that 36afb0ab648 and 55e59aa0525a
> are wrong and should be reverted.  It seems like they're an attempt to
> make 89128534f925 be done 'properly' but it also seems like the

Please be more specific.  The only obvious issue with the original patch
"ASoC: rt5677: Add ACPI support" is that it adds an I2C ID instead of an
ACPI ID.  I don't have 36afb0ab648 so I've no idea what it is and
55e59aa0525a is "ASoC: rt5677: Move platform code to board file" which
is a code motion patch and looks more like stylistic faff around the
shambles that is ACPI than anything else.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)