linux-kernel - Re: [PATCH] usb:xhci:Fix regression when ATI chipsets detected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170823230319.GC5193@kroah.com>
Date:   Wed, 23 Aug 2017 16:03:19 -0700
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sandeep Singh <Sandeep.Singh@....com>
Cc:     mathias.nyman@...el.com, ben@...adent.org.uk,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Nehal Shah <Nehal-bakulchandra.Shah@....com>
Subject: Re: [PATCH] usb:xhci:Fix regression when ATI chipsets detected

On Wed, Aug 23, 2017 at 04:26:00PM +0530, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@....com>
> 
> The following commit cause a regression on ATI chipsets.
> 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain
> failing HP keyboard on reset after resume")'
> 
> This causes pinfo->smbus_dev to be wrongly set to NULL on
> systems with the ATI chipset that this function checks for first.
> 
> Added conditional check for AMD chipsets to avoid the overwriting
> pinfo->smbus_dev.
> 
> Reported-by: Ben Hutchings <ben@...adent.org.uk>
> Signed-off-by: Sandeep Singh <Sandeep.Singh@....com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>
> cc: Nehal Shah <Nehal-bakulchandra.Shah@....com>

A "Fixes:" tag here would be good, as would a "cc:
stable@...r.kernel.org" right?

And you have tested this out well, right?

thanks,

greg k-h