linux-kernel - [PATCH] x86: use KERN_CONT in dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <599EB4FB02000078001730B8@prv-mh.provo.novell.com>
Date:   Thu, 24 Aug 2017 03:14:03 -0600
From:   "Jan Beulich" <JBeulich@...e.com>
To:     <mingo@...e.hu>, <tglx@...utronix.de>, <hpa@...or.com>
Cc:     <linux-kernel@...r.kernel.org>
Subject: [PATCH] x86: use KERN_CONT in dump_pagetable()

The lack of newlines in preceding format strings is a clear indication
that these were meant to be continuations of one another, and indeed
output ends up quite a bit more compact (and readable) that way.

Signed-off-by: Jan Beulich <jbeulich@...e.com>
---
 arch/x86/mm/fault.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- 4.13-rc6/arch/x86/mm/fault.c
+++ 4.13-rc6-x86-dumppgt-cont/arch/x86/mm/fault.c
@@ -415,9 +415,9 @@ static void dump_pagetable(unsigned long
 		goto out;
 
 	pte = pte_offset_kernel(pmd, address);
-	printk("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
+	printk(KERN_CONT "*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte));
 out:
-	printk("\n");
+	printk(KERN_CONT "\n");
 }
 
 #else /* CONFIG_X86_64: */
@@ -574,7 +574,7 @@ static void dump_pagetable(unsigned long
 	if (bad_address(p4d))
 		goto bad;
 
-	printk("P4D %lx ", p4d_val(*p4d));
+	printk(KERN_CONT "P4D %lx ", p4d_val(*p4d));
 	if (!p4d_present(*p4d) || p4d_large(*p4d))
 		goto out;
 
@@ -582,7 +582,7 @@ static void dump_pagetable(unsigned long
 	if (bad_address(pud))
 		goto bad;
 
-	printk("PUD %lx ", pud_val(*pud));
+	printk(KERN_CONT "PUD %lx ", pud_val(*pud));
 	if (!pud_present(*pud) || pud_large(*pud))
 		goto out;
 
@@ -590,7 +590,7 @@ static void dump_pagetable(unsigned long
 	if (bad_address(pmd))
 		goto bad;
 
-	printk("PMD %lx ", pmd_val(*pmd));
+	printk(KERN_CONT "PMD %lx ", pmd_val(*pmd));
 	if (!pmd_present(*pmd) || pmd_large(*pmd))
 		goto out;
 
@@ -598,9 +598,9 @@ static void dump_pagetable(unsigned long
 	if (bad_address(pte))
 		goto bad;
 
-	printk("PTE %lx", pte_val(*pte));
+	printk(KERN_CONT "PTE %lx", pte_val(*pte));
 out:
-	printk("\n");
+	printk(KERN_CONT "\n");
 	return;
 bad:
 	printk("BAD\n");