linux-kernel - Re: [PATCH] clk: versatile: make clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170824095442.GC11316@e110455-lin.cambridge.arm.com>
Date:   Thu, 24 Aug 2017 10:54:42 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, sudeep.holla@....com,
        lorenzo.pieralisi@....com, mturquette@...libre.com,
        sboyd@...eaurora.org, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: versatile: make clk_ops const

On Tue, Aug 22, 2017 at 07:36:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a
> clk_init_data structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Acked-by: Liviu Dudau <Liviu.Dudau@....com>

Thanks for the patch!

Sudeep, can you going to pick this up for 4.14?

Best regards,
Liviu

> ---
>  drivers/clk/versatile/clk-vexpress-osc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
> index 7e5add7..e7a868b 100644
> --- a/drivers/clk/versatile/clk-vexpress-osc.c
> +++ b/drivers/clk/versatile/clk-vexpress-osc.c
> @@ -61,7 +61,7 @@ static int vexpress_osc_set_rate(struct clk_hw *hw, unsigned long rate,
>  	return regmap_write(osc->reg, 0, rate);
>  }
>  
> -static struct clk_ops vexpress_osc_ops = {
> +static const struct clk_ops vexpress_osc_ops = {
>  	.recalc_rate = vexpress_osc_recalc_rate,
>  	.round_rate = vexpress_osc_round_rate,
>  	.set_rate = vexpress_osc_set_rate,
> -- 
> 1.9.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯