linux-kernel - Re: [PATCH] ASoC: Add a sanity check before using dai driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170824101826.htrevrhhgez2pgoe@sirena.org.uk>
Date:   Thu, 24 Aug 2017 11:18:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     jeffy <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, tiwai@...e.de,
        dolinux.peng@...il.com, Jaroslav Kysela <perex@...ex.cz>,
        alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] ASoC: Add a sanity check before using dai driver name

On Thu, Aug 24, 2017 at 11:29:42AM +0800, jeffy wrote:

> and i was trying to do something like:
> if (dlc->dai_name && strcmp(dai->name, dlc->dai_name)
>     && (!dai->driver->name || strcmp(dai->driver->name, dlc->dai_name)))
>    continue;

> which is add an accept case for: dai driver name is valid and matches the
> dai name we are looking for...

Writing it as one if statement would at least be clearer.  I can't
remember the patch you proposed at this point but the above looks
plausible.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)