linux-kernel - Re: [PATCH] irqchip: mmp: make mmp_intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8760dd9rl1.fsf@arm.com>
Date:   Thu, 24 Aug 2017 11:40:26 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, tglx@...utronix.de, jason@...edaemon.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: mmp: make mmp_intc_conf const

On Thu, Aug 24 2017 at  3:56:21 pm BST, Bhumika Goyal <bhumirks@...il.com> wrote:
> Make these const as they are only used during a copy operation. Done
> using Coccinelle.
>
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct mmp_intc_conf s = {...};
>
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
>
> @good1@
> position ref.p;
> identifier match.s,f,c;
> expression e;
> @@
> (
> e = s@p
> |
> e = s@p.f
> |
> c(...,s@p.f,...)
> |
> c(...,s@p,...)
> )
>
> @bad depends on  !good1@
> position ref.p;
> identifier match.s;
> @@
> s@p
>
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct mmp_intc_conf s;
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Can you please post these fixes as a series instead of individual
patches? It would make the maintainers' life much easier. I'll apply
this patch anyway, but please keep this in mind for the future.

Thanks,

	M.
-- 
Jazz is not dead, it just smell funny.