linux-kernel - Re: [PATCH] ARM: at91: Replace uses of virt_to_phys with __pa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <062c5218-3370-905a-d113-4d9526d13cd1@microchip.com>
Date:   Thu, 24 Aug 2017 14:09:08 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:     Ludovic Desroches <ludovic.desroches@...el.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: at91: Replace uses of virt_to_phys with __pa_symbol

On 24/08/2017 at 13:44, Alexandre Belloni wrote:
> The PM code wrongly uses virt_to_phys() instead of __pa_symbol() and was
> not updated by commit 64fc2a947a98 ("ARM: 8641/1: treewide: Replace uses of
> virt_to_phys with __pa_symbol") because it was not yet in tree.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>  arch/arm/mach-at91/pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index b1a59d638321..ccaaaa138d13 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -535,8 +535,8 @@ static void __init at91_pm_backup_init(void)
>  	}
>  
>  	pm_bu->suspended = 0;
> -	pm_bu->canary = virt_to_phys(&canary);
> -	pm_bu->resume = virt_to_phys(cpu_resume);
> +	pm_bu->canary = __pa_symbol(&canary);
> +	pm_bu->resume = __pa_symbol(cpu_resume);
>  
>  	return;
>  
> 


-- 
Nicolas Ferre