linux-kernel - Re: [RESEND PATCH v5 10/16] ARM: dts: zynq: Add generic compatible string for I2C EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2017 15:44:50 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Javier Martinez Canillas <javier@...hile0.org>,
        Michal Simek <michal.simek@...inx.com>,
        Arnd Bergmann <arnd@...db.de>
CC:     Linux Kernel <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Rob Herring <robh@...nel.org>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RESEND PATCH v5 10/16] ARM: dts: zynq: Add generic compatible
 string for I2C EEPROM

Hi,

On 23.8.2017 16:28, Javier Martinez Canillas wrote:
> Hello Michal,
> 
> On Wed, Jun 21, 2017 at 1:43 PM, Michal Simek <michal.simek@...inx.com> wrote:
>> On 15.6.2017 20:54, Javier Martinez Canillas wrote:
>>> The at24 driver allows to register I2C EEPROM chips using different vendor
>>> and devices, but the I2C subsystem does not take the vendor into account
>>> when matching using the I2C table since it only has device entries.
>>>
>>> But when matching using an OF table, both the vendor and device has to be
>>> taken into account so the driver defines only a set of compatible strings
>>> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>>>
>>> So add this generic fallback to the device node compatible string to make
>>> the device to match the driver using the OF device ID table.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@...hile0.org>
>>>
> 
> [snip]
> 
>>> --- a/arch/arm/boot/dts/zynq-zc706.dts
>>> +++ b/arch/arm/boot/dts/zynq-zc706.dts
>>> @@ -92,7 +92,7 @@
>>>                       #size-cells = <0>;
>>>                       reg = <2>;
>>>                       eeprom@54 {
>>> -                             compatible = "at,24c08";
>>> +                             compatible = "atmel,24c08";
>>>                               reg = <0x54>;
>>>                       };
>>>               };
>>>
>>
>> Acked-by: Michal Simek <michal.simek@...inx.com>
>>
> 
> Same question than for the other patch, could you please also apply this?
> 
> Sorry for not being clear in the cover letter that the patches could
> be applied independently.

Ok. Applied to
https://github.com/Xilinx/linux-xlnx/commits/zynq/dt

Will wait if something else pop up.

Arnd: If you want to take this directly, feel free to do it.

Thanks,
Michal