linux-kernel - Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2017 09:47:37 -0400
From:   Tom Rini <trini@...sulko.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        Mark Brown <broonie@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

On Thu, Aug 24, 2017 at 03:26:00PM +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-24 at 07:15 -0400, Tom Rini wrote:
> > On Thu, Aug 24, 2017 at 10:39:09AM +0300, Andy Shevchenko wrote:
> > > On Wed, 2017-08-23 at 20:05 -0400, Tom Rini wrote:
> > > > On Wed, Aug 23, 2017 at 01:39:12PM -0400, Tom Rini wrote:
> > > > > On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:
> > > > > 
> > > > > > Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide
> > > > > > platform
> > > > > > data
> > > > > > in the module sources") does not fix your issue?
> > > > > 
> > > > > As that's not in master yet I can't tell.  Can you give me a
> > > > > pointer
> > > > > to
> > > > > somewhere?
> > > 
> > > It's in ASoC next at least.
> > > 
> > > > >   Thanks!
> > > > 
> > > > OK, my bad, it has a different hash upstream, but no, that change
> > > > doesn't fix things as I see the problem on top of Linus'
> > > > tree.  Thanks!
> > > 
> > > Interesting...
> > > 
> > > The only bug so far I saw is the following one
> > > 
> > > https://bugzilla.kernel.org/show_bug.cgi?id=196397
> > > 
> > > ...and above commit fixes it.
> > > 
> > > Can you place somewhere the bundle of the following:
> > > 
> > > 1. Output file (tables.dat) of
> > > 	% acpidump -o tables.dat
> > 
> > https://gist.github.com/trini/b9a9a547e37cb812506a22e18cd2aff5
> > 
> > > 2. Output of
> > > 	% cat /proc/interrupts
> > 
> > https://gist.github.com/trini/39a5d88a5ecb9b71336ff5fe9da7c720
> > 
> > > 3. Output of
> > > 	% lspci -vv -xx
> > 
> > https://gist.github.com/trini/e81ab21909eeaa05ea50dc0596d23c14
> > 
> > > 4. Output of
> > > 	% grep -H 15 /sys/bus/acpi/devices/*/status
> > 
> > https://gist.github.com/trini/698dc284634ad9e1cfbafad8e705de5f
> 
> Thanks!
> 
> I have checked those files and found that device is in the table and
> pretty much properly defined ACPI I2C slave.
> 
> The change in the driver you referred to makes the change to modalias.
> 
> Thus, I'm suspecting that your user space helper either has some hard
> coded values for previous case, or just broken.
> 
> Can you also check is the codec module loaded (lsmod) and, if it's not,
> load it manually and check if sound works again.
> 
> P.S. In any case you need the patch mentioned in bug #196397

I've applied "ASoC: rt5677: Hide platform data in the module sources"
manually to Linus' tree and still see the same problem.  Perhaps there's
now some missing alias information that really needs to still be
provided?  snd-soc-sst-bdw-rt5677-mach is not loaded and I can't
manually load it later on.  What user space helper configuration am I
supposed to need to have now, for this to work?  Thanks!

-- 
Tom

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)