linux-kernel - Re: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in dcon_freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170824140737.ke2ebr5u73jrm7qq@mwanda>
Date:   Thu, 24 Aug 2017 17:07:37 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Shurong Zhang <zhang_shurong@...mail.com>
Cc:     Jens Frederich <jfrederich@...il.com>,
        Daniel Drake <dsd@...top.org>,
        Jon Nettleton <jon.nettleton@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel <devel@...verdev.osuosl.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in
 dcon_freeze_store()

On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
> 
> Signed-off-by: Shurong Zhang <zhang_shurong@...mail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..f9d9465 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,6 @@ static ssize_t dcon_freeze_store(struct device *dev,
>  	if (ret)
>  		return ret;
>  
> -	pr_info("dcon_freeze_store: %lu\n", output);
>  

Delete a blank line as well.  We don't allow two blank lines in a row.

regards,
dan carpenter