linux-kernel - Re: [PATCH] rtc: mxc: avoid disabling interrupts on device close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5B2MxGt8DnXU8v1DG9LdbvxyN0FFDJm=dTO=18i=1r4mA@mail.gmail.com>
Date:   Thu, 24 Aug 2017 11:16:11 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     linux-rtc@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] rtc: mxc: avoid disabling interrupts on device close

On Wed, Aug 23, 2017 at 7:00 PM, Alexandre Belloni
<alexandre.belloni@...e-electrons.com> wrote:
> Currently, the IRQs are disabled when the rtc character device is closed.
> This means that the device needs to stay open to get alarms while the usual
> use case will open the device, set the alarm and close the device as is
> done in rtcwake.
>
> Keep the alarm functional on character device release so the platform can
> actually wakeup
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

Makes sense, thanks:

Reviewed-by: Fabio Estevam <fabio.estevam@....com>