linux-kernel - Re: [PATCH] Staging: Android: fix code style in ion_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee794dae-e638-69c1-3ea2-2953ab84c937@redhat.com>
Date:   Thu, 24 Aug 2017 08:55:49 -0700
From:   Laura Abbott <labbott@...hat.com>
To:     Abishek V Ashok <abishekvashok@...il.com>,
        gregkh@...uxfoundation.org, sumit.semwal@...aro.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c

On 08/24/2017 08:40 AM, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
> 

You've done two things in this patch, please stick to a single
change per patch.

> Signed-off-by: Abhishek V Ashok <abishekvashok@...il.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index a0949bc0..1589b9e0 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -31,7 +31,6 @@ struct ion_cma_heap {
> 
>  #define to_cma_heap(x) container_of(x, struct ion_cma_heap, heap)
> 
> -
>  /* ION CMA heap operations functions */
>  static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  			    unsigned long len,
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!pages)
>  		return -ENOMEM;
> 
> -	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> +	table = kmalloc(sizeof(struct * table), GFP_KERNEL);
>  	if (!table)
>  		goto err;
> 
> --
> 2.11.0
>