linux-kernel - Re: [PATCH] of/device: Prevent buffer overflow in of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+FpKHb59J_UEx2ndOqM9aHKe-Loopos4UW=uS+dk9+9g@mail.gmail.com>
Date:   Thu, 24 Aug 2017 11:24:51 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Frank Rowand <frowand.list@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] of/device: Prevent buffer overflow in of_device_modalias()

On Wed, Aug 23, 2017 at 8:04 PM, Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
> As of_device_get_modalias() returns the number of bytes that would have
> been written to the target string, regardless of how much did fit in the
> buffer, it's possible that the returned index points beyond the buffer
> passed to of_device_modalias() - causing memory beyond the buffer to be
> null terminated.

I guess ibmebus and macio had this bug for some time because I just
copied those implementations.

Applying both patches. Thanks.

Rob