linux-kernel - Re: [PATCH] Staging: Android: fix code style in ion_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1503607848.12569.12.camel@perches.com>
Date:   Thu, 24 Aug 2017 13:50:48 -0700
From:   Joe Perches <joe@...ches.com>
To:     Abishek V Ashok <abishekvashok@...il.com>, labbott@...hat.com,
        gregkh@...uxfoundation.org, sumit.semwal@...aro.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c

On Thu, 2017-08-24 at 21:10 +0530, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
[]
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!pages)
>  		return -ENOMEM;
> 
> -	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> +	table = kmalloc(sizeof(struct * table), GFP_KERNEL);

Please make sure you compile the files modified by
your proposed patches before sending the patches.