linux-kernel - Re: [PATCH v3] pty: Repair TIOCGPTPEER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2017 23:01:21 +0200
From:   Stefan Lippers-Hollmann <s.l-h@....de>
To:     ebiederm@...ssion.com (Eric W. Biederman)
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Christian Brauner <christian.brauner@...onical.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Thorsten Leemhuis <regressions@...mhuis.info>
Subject: Re: [PATCH v3] pty: Repair TIOCGPTPEER

Hi

On 2017-08-24, Eric W. Biederman wrote:
> The implementation of TIOCGPTPEER has two issues.
> 
> When /dev/ptmx (as opposed to /dev/pts/ptmx) is opened the wrong
> vfsmount is passed to dentry_open.  Which results in the kernel displaying
> the wrong pathname for the peer.

[...]

> v2: Lots of fixes to make the code actually work
> v3: Suggestions by Linus
>     - Removed the unnecessary initialization of filp in ptm_open_peer
>     - Simplified devpts_ptmx_path as gotos are no longer required

This version of the patch is working for me as well in all my test
(including pbuilder) so far, thanks a lot.

Regards
	Stefan Lippers-Hollmann

Content of type "application/pgp-signature" skipped