linux-kernel - Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45e1af7f-b931-ffd4-4447-b45f9038a089@ti.com>
Date:   Thu, 24 Aug 2017 16:58:11 -0500
From:   Suman Anna <s-anna@...com>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        <linux-kernel@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
CC:     Ohad Ben-Cohen <ohad@...ery.com>,
        <linux-remoteproc@...r.kernel.org>
Subject: Re: [PATCH 071/102] remoteproc/keystone: explicitly request exclusive
 reset control

Hi Bjorn,

On 07/19/2017 11:59 AM, Suman Anna wrote:
> On 07/19/2017 10:26 AM, Philipp Zabel wrote:
>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>> reset lines") started to transition the reset control request API calls
>> to explicitly state whether the driver needs exclusive or shared reset
>> control behavior. Convert all drivers requesting exclusive resets to the
>> explicit API call so the temporary transition helpers can be removed.
>>
>> No functional changes.
>>
>> Cc: Ohad Ben-Cohen <ohad@...ery.com>
>> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
>> Cc: linux-remoteproc@...r.kernel.org
>> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> 
> Acked-by: Suman Anna <s-anna@...com>

Can you pick this one and the other 2 related remoteproc patches?
Believe the subsystem maintainers have been picking these up, I see some
of the other related patches in linux-next but not these.

regards
Suman

> 
>> ---
>>  drivers/remoteproc/keystone_remoteproc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/keystone_remoteproc.c b/drivers/remoteproc/keystone_remoteproc.c
>> index 5f776bfd674a0..920fef072b364 100644
>> --- a/drivers/remoteproc/keystone_remoteproc.c
>> +++ b/drivers/remoteproc/keystone_remoteproc.c
>> @@ -410,7 +410,7 @@ static int keystone_rproc_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto free_rproc;
>>  
>> -	ksproc->reset = devm_reset_control_get(dev, NULL);
>> +	ksproc->reset = devm_reset_control_get_exclusive(dev, NULL);
>>  	if (IS_ERR(ksproc->reset)) {
>>  		ret = PTR_ERR(ksproc->reset);
>>  		goto free_rproc;
>>
>