linux-kernel - Re: [PATCH] Input: ambakmi: constify amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170824230842.GA22810@dtor-ws>
Date:   Thu, 24 Aug 2017 16:08:42 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux@...linux.org.uk, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: ambakmi: constify amba_id

On Wed, Aug 23, 2017 at 09:49:11PM +0530, Arvind Yadav wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied, thank you.

> ---
>  drivers/input/serio/ambakmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
> index c6606ca..ff3875c 100644
> --- a/drivers/input/serio/ambakmi.c
> +++ b/drivers/input/serio/ambakmi.c
> @@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev)
>  
>  static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume);
>  
> -static struct amba_id amba_kmi_idtable[] = {
> +static const struct amba_id amba_kmi_idtable[] = {
>  	{
>  		.id	= 0x00041050,
>  		.mask	= 0x000fffff,
> -- 
> 2.7.4
> 

-- 
Dmitry