linux-kernel - Re: [PATCH v7 01/12] powerpc/vas: Define macros, register fields and structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y3q8t1vr.fsf@concordia.ellerman.id.au>
Date:   Fri, 25 Aug 2017 19:47:36 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
Cc:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        mikey@...ling.org, stewart@...ux.vnet.ibm.com, apopple@....ibm.com,
        hbabu@...ibm.com, oohall@...il.com, linuxppc-dev@...abs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 01/12] powerpc/vas: Define macros, register fields and structures

Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> writes:

> diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h
> new file mode 100644
> index 0000000..c66aaf0
> --- /dev/null
> +++ b/arch/powerpc/platforms/powernv/vas.h
> @@ -0,0 +1,385 @@
...
> +
> +/*
> + * In-kernel state a VAS window. One per window.
> + */
> +struct vas_window {
> +	/* Fields common to send and receive windows */
> +	struct vas_instance *vinst;
> +	int winid;
> +	bool tx_win;		/* True if send window */
> +	bool nx_win;		/* True if NX window */
> +	bool user_win;		/* True if user space window */
> +	void *hvwc_map;		/* HV window context */
> +	void *uwc_map;		/* OS/User window context */
> +	pid_t pid;		/* Linux process id of owner */
> +
> +	/* Fields applicable only to send windows */
> +	void *paste_kaddr;
> +	char *paste_addr_name;
> +	struct vas_window *rxwin;
> +
> +	/* Feilds applicable only to receive windows */
> +	enum vas_cop_type cop;
> +	atomic_t num_txwins;

Just noticed this. You should probably use the new refcount_t type,
because AFAICS you're using this as a refcount.

cheers