linux-kernel - Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtC=uU_tRVmLXRx9bfUOED6c_V6XRdDc_1Gw+mRcwQbiAg@mail.gmail.com>
Date:   Fri, 25 Aug 2017 15:40:15 +0200
From:   Vincent Guittot <vincent.guittot@...aro.org>
To:     Brendan Jackman <brendan.jackman@....com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Joel Fernandes <joelaf@...gle.com>,
        Andres Oportus <andresoportus@...gle.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Josef Bacik <josef@...icpanda.com>,
        Morten Rasmussen <morten.rasmussen@....com>
Subject: Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1

On 25 August 2017 at 12:16, Brendan Jackman <brendan.jackman@....com> wrote:
> Since commit 83a0a96a5f26 ("sched/fair: Leverage the idle state info
> when choosing the "idlest" cpu") find_idlest_grou_cpu (formerly
> find_idlest_cpu) no longer returns -1.
>
> Signed-off-by: Brendan Jackman <brendan.jackman@....com>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> Cc: Josef Bacik <josef@...icpanda.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Morten Rasmussen <morten.rasmussen@....com>
> Cc: Peter Zijlstra <peterz@...radead.org>

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

> ---
>  kernel/sched/fair.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index f6e277c65235..4ccecbf825bf 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5583,7 +5583,7 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p
>                 }
>
>                 new_cpu = find_idlest_group_cpu(group, p, cpu);
> -               if (new_cpu == -1 || new_cpu == cpu) {
> +               if (new_cpu == cpu) {
>                         /* Now try balancing at a lower domain level of cpu */
>                         sd = sd->child;
>                         continue;
> --
> 2.14.1
>