linux-kernel - Re: [PATCH] trace-cmd report: Fix hash.key in option -w

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170825102229.1efedf40@gandalf.local.home>
Date:   Fri, 25 Aug 2017 10:22:29 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Ziqian SUN (Zamir)" <zsun@...hat.com>
Cc:     linux-kernel@...r.kernel.org, jkacur@...hat.com
Subject: Re: [PATCH] trace-cmd report: Fix hash.key in option -w

On Fri, 25 Aug 2017 13:47:49 +0800
"Ziqian SUN (Zamir)" <zsun@...hat.com> wrote:

> From: "Ziqian SUN (Zamir)" <zsun@...hat.com>
> 
> In add_wakeup function the hash list is created with hash.key = value.
> This makes add_sched function will never find a match with the key which
> results in trace-cmd report will never show the average latency with the
> following command:
> trace-cmd report -w -F 'sched_switch,sched_wakeup'
> With this patch, the command will show average latency as it used to be
> in v2.4.2 like
> 
> Average wakeup latency: 28.460 usecs
> Maximum Latency: 669.268 usecs at timestamp: 16337.629767
> Minimum Latency: 2.153 usecs at timestamp: 16337.533735
> 
> RT task timings:
> 
> Average wakeup latency: 23.106 usecs
> Maximum Latency: 57.482 usecs at timestamp: 16337.187531
> Minimum Latency: 4.127 usecs at timestamp: 16336.945209
> 
> Reported-by: Joe Mario <jmario@...hat.com>
> Signed-off-by: Ziqian SUN (Zamir) <zsun@...hat.com>

Thanks a lot Ziqian! Added. Will push out soon.

I need to update the stables too.

-- Steve