linux-kernel - Re: [PATCH] selftests/timers: make loop consistent with array size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e18e516-8577-8b0e-9f8c-37d08a44d958@kernel.org>
Date:   Fri, 25 Aug 2017 10:06:11 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        john.stultz@...aro.org, tglx@...utronix.de, sboyd@...eaurora.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests/timers: make loop consistent with array size

On 08/23/2017 10:07 AM, Benjamin Gaignard wrote:
> clocksource_list array is defined as char [10][30] so
> to initialise it we only have to iterate 10 times.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> ---
>  tools/testing/selftests/timers/clocksource-switch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/timers/clocksource-switch.c b/tools/testing/selftests/timers/clocksource-switch.c
> index 5ff1653..56fbfc1 100644
> --- a/tools/testing/selftests/timers/clocksource-switch.c
> +++ b/tools/testing/selftests/timers/clocksource-switch.c
> @@ -61,7 +61,7 @@ int get_clocksources(char list[][30])
>  
>  	close(fd);
>  
> -	for (i = 0; i < 30; i++)
> +	for (i = 0; i < 10; i++)
>  		list[i][0] = '\0';
>  
>  	head = buf;
> 

Good catch. Thanks. Applied to linux-kselftest next for 4.14-rc1.

thanks,
-- Shuah