lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170825174230.eb76bee4imj7fcjo@AntonyAntony.local>
Date:   Fri, 25 Aug 2017 19:42:30 +0200
From:   Antony Antony <antony@...nome.org>
To:     Code Kipper <codekipper@...il.com>
Cc:     Antony Antony <antony@...nome.org>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>, Icenowy Zheng <icenowy@...c.io>,
        linux-sunxi <linux-sunxi@...glegroups.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: allwinner: h5: add support for NanoPi NEO Plus
 2

Hi Code,

Thanks for the for the feed back. I will incorporate changes you suggest, 
disable the stuff on the header, remove de2, .. and send out v3 soon.

WiFi is a an Ampak AP6212A module, with Broadcom 43xx chip inside.
The device shows up, however, I see
I do see [    8.008301] brcmfmac: brcmf_sdio_htclk: HT Avail timeout 
(1000000): clkctl 0x
[   12.914950] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not readyeady

I will do more research about wlan0. Or disable initially.

regards,
-antony

On Fri, Aug 25, 2017 at 03:28:41PM +0200, Code Kipper wrote:
> On 25 August 2017 at 12:32, Antony Antony <antony@...nome.org> wrote:
> >         Add initial DT support for NanoPi NEO Plus 2 by FriendlyELEC
> >                 Allwinner quad core H5 Cortex A53 with an ARM Mali-450MP GPU
> >                 1 GB DDR3 RAM
> >                 8GB eMMC flash (Samsung KLM8G1WEPD-B031)
> >                 micro SD card slot
> >                 Gigabit Ethernet (external RTL8211E-VB-CG chip)
> >                 802.11 b/g/n WiFi, Bluetooth 4.0 (Ampak AP6212A module)
> >                 2x USB 2.0 host ports & 2x USB via headers
> >
> >     The DTS is based on OrangePi PC 2, sun50i-h5-orangepi-pc2
> >     Added dwmac-sun8i Gigabit Ethernet support based on
> >     Nano Pi Neo2 DT and the schematics.
> >
> > Signed-off-by: Antony Antony <antony@...nome.org>
> > ---
> >  arch/arm64/boot/dts/allwinner/Makefile             |   1 +
> >  .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 341 +++++++++++++++++++++
> >  2 files changed, 342 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile
> > index 108f12c..e6810c8 100644
> > --- a/arch/arm64/boot/dts/allwinner/Makefile
> > +++ b/arch/arm64/boot/dts/allwinner/Makefile
> > @@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-pc2.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-prime.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-orangepi-zero-plus2.dtb
> >  dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-nanopi-neo2.dtb
> > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-nanopi-neo-plus2.dtb
> >
> >  always         := $(dtb-y)
> >  subdir-y       := $(dts-dirs)
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> > new file mode 100644
> > index 0000000..d279ad8
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> > @@ -0,0 +1,341 @@
> > +/*
> > + * Copyright (C) 2017 Antony Antony <antony@...nome.org>
> > + * Copyright (C) 2016 ARM Ltd.
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This file is free software; you can redistribute it and/or
> > + *     modify it under the terms of the GNU General Public License as
> > + *     published by the Free Software Foundation; either version 2 of the
> > + *     License, or (at your option) any later version.
> > + *
> > + *     This file is distributed in the hope that it will be useful,
> > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *     GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + *     obtaining a copy of this software and associated documentation
> > + *     files (the "Software"), to deal in the Software without
> > + *     restriction, including without limitation the rights to use,
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or
> > + *     sell copies of the Software, and to permit persons to whom the
> > + *     Software is furnished to do so, subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and this permission notice shall be
> > + *     included in all copies or substantial portions of the Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun50i-h5.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/pinctrl/sun4i-a10.h>
> > +
> > +/ {
> > +       model = "FriendlyARM NanoPi NEO Plus2";
> > +       compatible = "friendlyarm,nanopi-neo-pus2", "allwinner,sun50i-h5";
> Hi,
> s/pus/plus
> > +
> > +       reg_vcc3v3: vcc3v3 {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "vcc3v3";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <3300000>;
> > +       };
> > +
> > +       aliases {
> > +               ethernet0 = &emac;
> > +               serial0 = &uart0;
> > +       };
> > +
> > +       chosen {
> > +               stdout-path = "serial0:115200n8";
> > +       };
> > +
> > +       leds {
> > +               compatible = "gpio-leds";
> > +
> > +               pwr {
> > +                       label = "orangepi:green:pwr";
> > +                       gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> > +                       default-state = "on";
> > +               };
> > +
> > +               status {
> > +                       label = "orangepi:red:status";
> > +                       gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>;
> > +               };
> > +       };
> Is this correct?...check against the schematic and also remove orangepi c&p.
> > +
> > +       r-gpio-keys {
> > +               compatible = "gpio-keys";
> > +
> > +               sw4 {
> > +                       label = "sw4";
> > +                       linux,code = <BTN_0>;
> > +                       gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>;
> > +               };
> > +       };
> Is there a key onboard?
> 
> > +
> > +       reg_gmac_3v3: gmac-3v3 {
> > +               compatible = "regulator-fixed";
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&gmac_power_pin_nanopi>;
> > +               regulator-name = "gmac-3v3";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <3300000>;
> > +               startup-delay-us = <100000>;
> > +               enable-active-high;
> > +               gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
> > +       };
> > +
> > +       vdd_cpux: gpio-regulator {
> > +               compatible = "regulator-gpio";
> > +
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&vdd_cpux_r_npi>;
> > +
> > +               regulator-name = "vdd-cpux";
> > +               regulator-type = "voltage";
> > +               regulator-boot-on;
> > +               regulator-always-on;
> > +               regulator-min-microvolt = <1100000>;
> > +               regulator-max-microvolt = <1300000>;
> > +               regulator-ramp-delay = <50>; /* 4ms */
> > +
> > +               gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
> > +               gpios-states = <0x1>;
> > +               states = <1100000 0x0
> > +                         1300000 0x1>;
> > +       };
> > +
> > +       wifi_pwrseq: wifi_pwrseq {
> > +               compatible = "mmc-pwrseq-simple";
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&wifi_en_npi>;
> > +               reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
> > +               post-power-on-delay-ms = <200>;
> > +       };
> > +};
> > +
> > +&codec {
> > +       allwinner,audio-routing =
> > +               "Line Out", "LINEOUT",
> > +               "MIC1", "Mic",
> > +               "Mic",  "MBIAS";
> > +       status = "okay";
> > +};
> > +
> > +&de {
> > +       status = "okay";
> > +};
> de2 stuff hasn't been delivered yet so don't include it.
> > +
> > +&ehci0 {
> > +       status = "okay";
> > +};
> > +
> > +&ehci1 {
> > +       status = "okay";
> > +};
> > +
> > +&ehci2 {
> > +       status = "okay";
> > +};
> USB 1 and 2 are on the header so should be disabled.
> > +
> > +&ehci3 {
> > +       status = "okay";
> > +};
> > +
> > +&emac {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&emac_rgmii_pins>;
> > +       phy-supply = <&reg_gmac_3v3>;
> > +       phy-handle = <&ext_rgmii_phy>;
> > +       phy-mode = "rgmii";
> > +       status = "okay";
> > +};
> > +
> > +&hdmi {
> > +       status = "okay";
> > +};
> ditto
> > +
> > +&ir {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&ir_pins_a>;
> > +       status = "okay";
> > +};
> No IR on the board, however it's on a header so disable or remove.
> > +
> > +&mdio {
> > +       ext_rgmii_phy: ethernet-phy@7 {
> > +               compatible = "ethernet-phy-ieee802.3-c22";
> > +               reg = <7>;
> > +       };
> > +};
> > +
> > +&mixer0 {
> > +       status = "okay";
> > +};
> de2 ditto
> > +
> > +&mmc0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> > +       vmmc-supply = <&reg_vcc3v3>;
> > +       bus-width = <4>;
> > +       cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */
> > +       status = "okay";
> > +};
> > +
> > +&mmc1 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&mmc1_pins_a>;
> > +       vmmc-supply = <&reg_vcc3v3>;
> > +       vqmmc-supply = <&reg_vcc3v3>;
> > +       mmc-pwrseq = <&wifi_pwrseq>;
> > +       bus-width = <4>;
> > +       non-removable;
> > +       boot_device = <0>;
> > +       status = "okay";
> > +
> > +       brcmf: bcrmf@1 {
> > +               reg = <1>;
> > +               compatible = "brcm,bcm4329-fmac";
> > +       };
> Incorrect wifi chip - just deliver what you've tested.
> > +};
> > +
> > +&mmc2 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&mmc2_8bit_pins>;
> > +       vmmc-supply = <&reg_vcc3v3>;
> > +       bus-width = <8>;
> > +       non-removable;
> > +       cap-mmc-hw-reset;
> > +       boot_device = <0>;
> > +       status = "okay";
> > +};
> > +
> > +&mmc2_8bit_pins {
> > +       /* Increase drive strength for DDR modes */
> > +       drive-strength = <40>;
> > +       /* eMMC is missing pull-ups */
> > +       bias-pull-up;
> > +};
> > +
> > +&ohci0 {
> > +       status = "okay";
> > +};
> > +
> > +&ohci1 {
> > +       status = "okay";
> > +};
> > +
> > +&ohci2 {
> > +       status = "okay";
> > +};
> > +
> > +&ohci3 {
> > +       status = "okay";
> > +};
> > +
> > +&tcon0 {
> > +       status = "okay";
> > +};
> de2 ditto
> > +
> > +&spi0 {
> > +       status = "okay";
> > +       spi-flash@0 {
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +               compatible = "jedec,spi-nor";
> > +               reg = <0>; /* Chip select 0 */
> > +               spi-max-frequency = <10000000>;
> > +               status = "okay";
> > +               partitions {
> > +                       compatible = "fixed-partitions";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +                       partition@0 {
> > +                               label = "uboot";
> > +                               reg = <0x0 0x100000>;
> > +                       };
> > +                       partition@...000 {
> > +                               label = "env";
> > +                               reg = <0x100000 0x100000>;
> > +                       };
> > +               };
> > +       };
> > +};
> spi0 is on the header and there is no spi flash.
> 
> BR,
> CK
> > +
> > +&pio {
> > +       leds_npi: led_pins@0 {
> > +               pins = "PA10";
> > +               function = "gpio_out";
> > +       };
> > +       gmac_power_pin_nanopi: gmac_power_pin@0 {
> > +                       pins = "PD6";
> > +                       function = "gpio_out";
> > +       };
> > +};
> > +
> > +&r_pio {
> > +       leds_r_npi: led_pins@0 {
> > +               pins = "PL10";
> > +               function = "gpio_out";
> > +       };
> > +
> > +       vdd_cpux_r_npi: regulator_pins@0 {
> > +               allwinner,pins = "PL6";
> > +               allwinner,function = "gpio_out";
> > +               allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> > +               allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> > +       };
> > +
> > +       wifi_en_npi: wifi_en_pin {
> > +               pins = "PL7";
> > +               function = "gpio_out";
> > +       };
> > +};
> > +
> > +&uart0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&uart0_pins_a>;
> > +       status = "okay";
> > +};
> > +
> > +&uart1 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&uart1_pins>;
> > +       status = "disabled";
> > +};
> > +
> > +&uart2 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&uart2_pins>;
> > +       status = "disabled";
> > +};
> > +
> > +&usb_otg {
> > +       dr_mode = "usb";
> > +       status = "okay";
> > +};
> > +
> > +&usbphy {
> > +       /* USB Type-A ports' VBUS is always on */
> > +       usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
> > +       status = "okay";
> > +};
> > --
> > 2.9.3
> >

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ