lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Aug 2017 19:51:04 +0200 From: Lukas Wunner <lukas@...ner.de> To: Colin King <colin.king@...onical.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org, Bjorn Helgaas <bhelgaas@...gle.com>, kernel-janitors@...r.kernel.org, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller On Fri, Aug 25, 2017 at 05:32:06PM +0100, Colin King wrote: > --- a/arch/x86/platform/intel-mid/pwr.c > +++ b/arch/x86/platform/intel-mid/pwr.c > @@ -444,7 +444,7 @@ static int mid_set_initial_state(struct mid_pwr *pwr, const u32 *states) > static int pnw_set_initial_state(struct mid_pwr *pwr) > { > /* On Penwell SRAM must stay powered on */ > - const u32 states[] = { > + static const u32 states[] = { > 0xf00fffff, /* PM_SSC(0) */ > 0xffffffff, /* PM_SSC(1) */ > 0xffffffff, /* PM_SSC(2) */ That's a known gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68725 There are hundreds of constant compound literals that are generated on the stack rather than stored in rodata, do you intend to file patches for all of them? Adding static everywhere is just a workaround that bloats the code. Fixing the root cause in gcc would make more sense. Just my 2 cents worth of course. Thanks, Lukas
Powered by blists - more mailing lists