linux-kernel - Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170825205721.GA11181@hades.home>
Date:   Fri, 25 Aug 2017 21:57:22 +0100
From:   Martyn Welch <martyn@...chs.me.uk>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     devel@...verdev.osuosl.org, Aaron Sierra <asierra@...-inc.com>,
        Alessio Igor Bogani <alessio.bogani@...ttra.eu>,
        Arnd Bergmann <arnd@...db.de>,
        Augusto Mecking Caringi <augustocaringi@...il.com>,
        Baoyou Xie <baoyou.xie@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Manohar Vanga <manohar.vanga@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 13/14] vme: tsi148: Improve 17 size determinations

On Fri, Aug 25, 2017 at 06:15:08PM +0200, SF Markus Elfring wrote:

<snip>

> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  		master_num--;
>  
>  		tsi148_device->flush_image =
> -			kmalloc(sizeof(struct vme_master_resource), GFP_KERNEL);
> +			kmalloc(sizeof(*tsi148_device->flush_image), GFP_KERNEL);

This line is now a tiny bit too long and needs to be broken over two lines.

Martyn