linux-kernel - Re: [patch 15/41] x86/idt: Remove tracing idt completely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2017 23:29:00 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Steven Rostedt <rostedt@...dmis.org>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>, Peter Anvin <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [patch 15/41] x86/idt: Remove tracing idt completely

On Fri, 25 Aug 2017, Thomas Gleixner wrote:
> On Fri, 25 Aug 2017, Steven Rostedt wrote:
> > On Fri, 25 Aug 2017 12:31:18 +0200
> > Thomas Gleixner <tglx@...utronix.de> wrote:
> > 
> > > No more users of the tracing idt. All exception tracepoints have been moved
> > > into the regular handlers. Get rid of the mess which shouldn't have been
> > > created in the first place.
> > > 
> > > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > > ---
> > >  arch/x86/entry/entry_32.S         |   12 -----
> > >  arch/x86/entry/entry_64.S         |   13 ------
> > >  arch/x86/include/asm/desc.h       |   82 ++------------------------------------
> > >  arch/x86/include/asm/entry_arch.h |   14 ++----
> > >  arch/x86/include/asm/hw_irq.h     |   20 ---------
> > >  arch/x86/include/asm/segment.h    |    3 -
> > >  arch/x86/kernel/tracepoint.c      |   43 -------------------
> > >  arch/x86/kernel/traps.c           |    6 --
> > >  8 files changed, 14 insertions(+), 179 deletions(-)
> > 
> > > --- a/arch/x86/include/asm/entry_arch.h
> > > +++ b/arch/x86/include/asm/entry_arch.h
> > > @@ -13,20 +13,16 @@
> > >  BUILD_INTERRUPT(reschedule_interrupt,RESCHEDULE_VECTOR)
> > >  BUILD_INTERRUPT(call_function_interrupt,CALL_FUNCTION_VECTOR)
> > >  BUILD_INTERRUPT(call_function_single_interrupt,CALL_FUNCTION_SINGLE_VECTOR)
> > > -BUILD_INTERRUPT3(irq_move_cleanup_interrupt, IRQ_MOVE_CLEANUP_VECTOR,
> > > -		 smp_irq_move_cleanup_interrupt)
> > > -BUILD_INTERRUPT3(reboot_interrupt, REBOOT_VECTOR, smp_reboot_interrupt)
> > > +BUILD_INTERRUPT(irq_move_cleanup_interrupt, IRQ_MOVE_CLEANUP_VECTOR)
> > > +BUILD_INTERRUPT(reboot_interrupt, REBOOT_VECTOR)
> > >  #endif
> > >  
> > >  BUILD_INTERRUPT(x86_platform_ipi, X86_PLATFORM_IPI_VECTOR)
> > >  
> > >  #ifdef CONFIG_HAVE_KVM
> > > -BUILD_INTERRUPT3(kvm_posted_intr_ipi, POSTED_INTR_VECTOR,
> > > -		 smp_kvm_posted_intr_ipi)
> > > -BUILD_INTERRUPT3(kvm_posted_intr_wakeup_ipi, POSTED_INTR_WAKEUP_VECTOR,
> > > -		 smp_kvm_posted_intr_wakeup_ipi)
> > > -BUILD_INTERRUPT3(kvm_posted_intr_nested_ipi, POSTED_INTR_NESTED_VECTOR,
> > > -		 smp_kvm_posted_intr_nested_ipi)
> > > +BUILD_INTERRUPT(kvm_posted_intr_ipi, POSTED_INTR_VECTOR)
> > > +BUILD_INTERRUPT(kvm_posted_intr_wakeup_ipi, POSTED_INTR_WAKEUP_VECTOR)
> > > +BUILD_INTERRUPT(kvm_posted_intr_nested_ipi, POSTED_INTR_NESTED_VECTOR)
> > >  #endif
> > 
> > 
> > This looks like a different change than what is specified in the change
> > log. It looks like a clean up. Shouldn't it be a separate patch?
> 
> Let me split it up.

OTOH, the BUILD_INTERRUPT3 users were explicit to avoid the
TRACE_BUILD_INTERRUPT() extra which was hidden behind BUILD_INTERRUPT. So
yes, it's a cleanup, but related.

Thanks,

	tglx