linux-kernel - RE: [PATCH] nfc: pn544: mei: constify mei_cl_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B74A091F9@hasmsx109.ger.corp.intel.com>
Date:   Sat, 26 Aug 2017 09:34:56 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        "sameo@...ux.intel.com" <sameo@...ux.intel.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: RE: [PATCH] nfc: pn544: mei: constify mei_cl_device_id


> 
> mei_cl_device_id are not supposed to change at runtime.
> mei driver is working with const 'id_table'. So mark the non-const
> mei_cl_device_id structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
Ack

>  drivers/nfc/pn544/mei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c index
> ad57a8e..a6c2e9c 100644
> --- a/drivers/nfc/pn544/mei.c
> +++ b/drivers/nfc/pn544/mei.c
> @@ -66,7 +66,7 @@ static int pn544_mei_remove(struct mei_cl_device
> *cldev)
>  	return 0;
>  }
> 
> -static struct mei_cl_device_id pn544_mei_tbl[] = {
> +static const struct mei_cl_device_id pn544_mei_tbl[] = {
>  	{ PN544_DRIVER_NAME, MEI_NFC_UUID, MEI_CL_VERSION_ANY},
> 
>  	/* required last entry */
> --
> 2.7.4