linux-kernel - Re: scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b218274a-da50-4f0c-2e55-cc6d708cef92@users.sourceforge.net>
Date:   Sat, 26 Aug 2017 13:17:00 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Joe Perches <joe@...ches.com>,
        Subhash Jadavani <subhashj@...eaurora.org>,
        linux-scsi@...r.kernel.org, linux-scsi-owner@...r.kernel.org
Cc:     "James E. J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Vinayak Holikatti <vinholikatti@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: scsi: ufs: Delete an error message for a failed memory allocation
 in ufshcd_memory_alloc()

>> PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation 
>> (via dmam_alloc_coherent() APIs) and tries to print out the message on 
>> allocation failure. Although i don't know "out of memory" messages will 
>> be printed out by dmam_alloc_coherent() APIs or not. If it does print it 
>> out then we might want to remove our local memory allocation failure log 
>> messages.
> 
> Basically most everything that has a gfp_t argument does a
> dump_stack() on OOM unless __GFP_NOWARN is specified by that gfp_t.

How do you think about to continue the clarification for this aspect
of the involved programming interfaces?

Regards,
Markus