linux-kernel - Re: [patch V2 35/44] x86/idt: Switch early trap init to IDT tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79d8e408-f51f-4dbd-68f3-16cdb95de2f8@oracle.com>
Date:   Sat, 26 Aug 2017 11:07:18 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Juergen Gross <jgross@...e.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>, Peter Anvin <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [patch V2 35/44] x86/idt: Switch early trap init to IDT tables



On 08/26/2017 09:05 AM, Thomas Gleixner wrote:

> 
> What occured to me right now, is that the patch removes:
> 
>       load_idt(&idt_descr);
> 
> from the original function without adding it to the new one. 

Right, that's exactly what was broken for Xen.

> So that needs
> to be fixed, but not in the XEN code. It simply wants to be added to
> idt_setup_early_traps(). I'll send out a V3 of that particular patch.

Yes, that will work too (and keep original logic).

-boris