[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20170826060446.ezohk7527vuphcy7@mwanda>
Date: Sat, 26 Aug 2017 09:04:46 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Oleg Drokin <oleg.drokin@...el.com>
Cc: Andreas Dilger <andreas.dilger@...el.com>,
James Simmons <jsimmons@...radead.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Ben Evans <bevans@...y.com>,
Baoyou Xie <baoyou.xie@...aro.org>,
Stephen Champion <schamp@....com>, frank zago <fzago@...y.com>,
Henri Doreau <henri.doreau@....fr>,
lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 3/3] staging: lustre: obdclass: fix checking for
obd_init_checks()
The obd_init_checks() function can either return -EOVERFLOW or -EINVAL
but we accidentally ignore -EINVAL returns.
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
---
This patch is the right thing, but it's always a bit risky turning on
new checks and I haven't tested this.
diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 545358923271..2df218b010e1 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -448,7 +448,7 @@ static int __init obdclass_init(void)
obd_zombie_impexp_init();
err = obd_init_checks();
- if (err == -EOVERFLOW)
+ if (err)
return err;
class_init_uuidlist();
Powered by blists - more mailing lists