linux-kernel - Re: [PATCH 2/6] staging: usb: typec: Check for port type for Try.SRC/Try.SNK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170827172027.GL22819@roeck-us.net>
Date:   Sun, 27 Aug 2017 10:20:27 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] staging: usb: typec: Check for port type for
 Try.SRC/Try.SNK

On Sat, Aug 26, 2017 at 10:24:12PM -0700, Badhri Jagan Sridharan wrote:
> Enable Try.SRC or Try.SNK only when port_type is
> DRP. Try.SRC or Try.SNK state machines are not
> valid for SRC only or SNK only ports.
> 
> Signed-off-by: Badhri Jagan Sridharan <Badhri@...gle.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/staging/typec/tcpm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/typec/tcpm.c b/drivers/staging/typec/tcpm.c
> index 6c045ac9c42a..1219e3bc13ef 100644
> --- a/drivers/staging/typec/tcpm.c
> +++ b/drivers/staging/typec/tcpm.c
> @@ -328,10 +328,12 @@ struct pd_rx_event {
>  	 (tcpm_cc_is_audio((port)->cc2) && tcpm_cc_is_open((port)->cc1)))
>  
>  #define tcpm_try_snk(port) \
> -	((port)->try_snk_count == 0 && (port)->try_role == TYPEC_SINK)
> +	((port)->try_snk_count == 0 && (port)->try_role == TYPEC_SINK && \
> +	(port)->port_type == TYPEC_PORT_DRP)
>  
>  #define tcpm_try_src(port) \
> -	((port)->try_src_count == 0 && (port)->try_role == TYPEC_SOURCE)
> +	((port)->try_src_count == 0 && (port)->try_role == TYPEC_SOURCE && \
> +	(port)->port_type == TYPEC_PORT_DRP)
>  
>  static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
>  {
> -- 
> 2.14.1.342.g6490525c54-goog
>