linux-kernel - Re: [PATCH v2 RESEND 1/2] dt-bindings: serial: 8250: Add MediaTek BTIF controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Aug 2017 22:00:55 +0300
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     sean.wang@...iatek.com, robh+dt@...nel.org,
        gregkh@...uxfoundation.org, jslaby@...e.com,
        andriy.shevchenko@...ux.intel.com, robert.jarzmik@...e.fr,
        arnd@...db.de, p.zabel@...gutronix.de, joel@....id.au,
        david@...hnology.com, jan.kiszka@...mens.com,
        heikki.krogerus@...ux.intel.com, hpeter@...il.com, vigneshr@...com,
        tthayer@...nsource.altera.com
Cc:     devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND 1/2] dt-bindings: serial: 8250: Add MediaTek
 BTIF controller bindings



On 08/19/2017 09:06 PM, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Document the devicetree bindings in 8250.txt for MediaTek BTIF
> controller which could be found on MT7622 and MT7623 SoC.
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>   Documentation/devicetree/bindings/serial/8250.txt | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt
> index 419ff6c..7528d90 100644
> --- a/Documentation/devicetree/bindings/serial/8250.txt
> +++ b/Documentation/devicetree/bindings/serial/8250.txt
> @@ -14,6 +14,9 @@ Required properties:
>   	  tegra132, or tegra210.
>   	- "nxp,lpc3220-uart"
>   	- "ralink,rt2880-uart"
> +	- For MediaTek MT7623, must contain "mediatek,mt7623-btif"
> +	- For other MediaTek SoCs , must contain "mediatek,<chip>-btif",
> +	  "mediatek,mt7623-btif" where <chip> is mt7622.

Hm, to me that's confusing. What about:
"mediatek,mt7623-btif": for MediaTek MT7623
"mediatek,mt7622-btif", "mediatek,mt7623-btif": for MediaTek MT7622

If in the future we have more SoCs that support the BTIF, we should add them 
like the mt7622 case.

Make sense?

Regards,
Matthias