linux-kernel - Re: [PATCH] m68knommu: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Aug 2017 21:09:59 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Angelo Dureghello <angelo@...am.it>
Cc:     Greg Ungerer <gerg@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68knommu: remove dead code

On 27/08/2017 at 13:22:09 +0200, Angelo Dureghello wrote:
> Hi,
> 
> just to inform you that i have in mind to add spi(soon, at least seems
> just a matter con Kconfig changes) and usdhc(later)
> drivers/support for stmark2 mcf5441x based board.
> But no problem, in case i'll re-add the this code as needed.
> 

I think it is easy enough to reintroduce init_BSP with your patch. It is
unfortunate that this useless function stayed that way so long, waiting
for a real user :)

> On 24/08/2017 16:34, Alexandre Belloni wrote:
> > As CONFIG_RTC_DRV_M5441x doesn't exist because the driver never made it
> > upstream, there is no device to register. Remove code that is never
> > compiled and init_BSP() as it doesn't do anything.
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> > ---
> >   arch/m68k/coldfire/m5441x.c | 37 -------------------------------------
> >   1 file changed, 37 deletions(-)
> > 
> > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c
> > index dc589b039b62..04fd7fde9fb3 100644
> > --- a/arch/m68k/coldfire/m5441x.c
> > +++ b/arch/m68k/coldfire/m5441x.c
> > @@ -222,40 +222,3 @@ void __init config_BSP(char *commandp, int size)
> >   	m5441x_uarts_init();
> >   	m5441x_fec_init();
> >   }
> > -
> > -
> > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> > -static struct resource m5441x_rtc_resources[] = {
> > -	{
> > -		.start		= MCFRTC_BASE,
> > -		.end		= MCFRTC_BASE + MCFRTC_SIZE - 1,
> > -		.flags		= IORESOURCE_MEM,
> > -	},
> > -	{
> > -		.start		= MCF_IRQ_RTC,
> > -		.end		= MCF_IRQ_RTC,
> > -		.flags		= IORESOURCE_IRQ,
> > -	},
> > -};
> > -
> > -static struct platform_device m5441x_rtc = {
> > -	.name			= "mcfrtc",
> > -	.id			= 0,
> > -	.resource		= m5441x_rtc_resources,
> > -	.num_resources		= ARRAY_SIZE(m5441x_rtc_resources),
> > -};
> > -#endif
> > -
> > -static struct platform_device *m5441x_devices[] __initdata = {
> > -#if IS_ENABLED(CONFIG_RTC_DRV_M5441x)
> > -	&m5441x_rtc,
> > -#endif
> > -};
> > -
> > -static int __init init_BSP(void)
> > -{
> > -	platform_add_devices(m5441x_devices, ARRAY_SIZE(m5441x_devices));
> > -	return 0;
> > -}
> > -
> > -arch_initcall(init_BSP);
> > 
> 
> Regards,
> Angelo

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com