linux-kernel - Re: [PATCH] staging: atomisp: constify v4l2_subdev_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170827214525.qw4oycwsrhvhcwim@valkosipuli.retiisi.org.uk>
Date:   Mon, 28 Aug 2017 00:45:25 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     mchehab@...nel.org, gregkh@...uxfoundation.org,
        hdegoede@...hat.com, alan@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: atomisp: constify v4l2_subdev_sensor_ops

Hi Arvind,

On Sun, Aug 27, 2017 at 11:26:39AM +0530, Arvind Yadav wrote:
> v4l2_subdev_sensor_ops are not supposed to change at runtime.
> v4l2_subdev_sensor_ops are working with const 'sensor' field of
> sturct v4l2_subdev_ops. So mark the non-const v4l2_subdev_sensor_ops
> structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks for the patch. The change has already been made by this patch:

commit 65058214f5c2ebe844916b92d1bece64fd00206e
Author: Julia Lawall <Julia.Lawall@...6.fr>
Date:   Tue Aug 8 06:58:29 2017 -0400

    media: staging: media: atomisp: constify video_subdev structures
    
    These structures are both stored in fields of v4l2_subdev_ops
    structures, all of which are const, so these structures can be
    const as well.
    
    Done with the help of Coccinelle.
    
    Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@...pensource.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi