linux-kernel - Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e054135-b825-5d3e-e508-201589b0c451@suse.de>
Date:   Sun, 27 Aug 2017 12:28:38 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        ????????? <jiang.liqin@...iatech.com>,
        linux-kernel@...r.kernel.org, Roc He <hepeng@...oo.tv>
Subject: Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295

Am 27.08.2017 um 10:27 schrieb Alexandre Belloni:
> On 27/08/2017 at 04:30:08 +0200, Andreas Färber wrote:
>> Am 27.08.2017 um 04:05 schrieb Andrew Lunn:
>> By that same argument we could ask why so many drivers (and mine, too)
>> are calling rtc_valid_tm() when __rtc_read_time() calls it again...
> 
> Most of them probably predates the introduction of the check in
> __rtc_read_time().

Replacing with 0 here then.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)