linux-kernel - Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d45c4034-1bb9-e812-8853-e56cf6f128de@gmail.com>
Date:   Mon, 28 Aug 2017 22:23:38 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        linux-leds@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Paul Mackerras <paulus@...ba.org>, Pavel Machek <pavel@....cz>,
        Richard Purdie <rpurdie@...ys.net>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] leds-PowerNV: Delete an error message for a failed memory
 allocation in powernv_led_create()

Hi Markus,

Thanks for the patch.

On 08/27/2017 10:10 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 27 Aug 2017 22:00:22 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/leds/leds-powernv.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c
> index b2a98c7b521b..b1adbd70ce2e 100644
> --- a/drivers/leds/leds-powernv.c
> +++ b/drivers/leds/leds-powernv.c
> @@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev,
>  	powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
>  						powernv_led->loc_code,
>  						led_type_desc);
> -	if (!powernv_led->cdev.name) {
> -		dev_err(dev,
> -			"%s: Memory allocation failed for classdev name\n",
> -			__func__);
> +	if (!powernv_led->cdev.name)
>  		return -ENOMEM;
> -	}
>  
>  	powernv_led->cdev.brightness_set_blocking = powernv_brightness_set;
>  	powernv_led->cdev.brightness_get = powernv_brightness_get;
> 

Applied.

-- 
Best regards,
Jacek Anaszewski