linux-kernel - Re: [PATCH] selinux: constify nf_hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhQzXMzOv0JsLWHd0sfB2S0T_U2Ax-dGwiedOHV4vKu-AA@mail.gmail.com>
Date:   Mon, 28 Aug 2017 17:34:31 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     selinux@...ho.nsa.gov, serge@...lyn.com,
        James Morris <james.l.morris@...cle.com>,
        Eric Paris <eparis@...isplace.org>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH] selinux: constify nf_hook_ops

On Sat, Aug 26, 2017 at 6:47 AM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> nf_hook_ops are not supposed to change at runtime. nf_register_net_hooks
> and nf_unregister_net_hooks are working with const nf_hook_ops.
> So mark the non-const nf_hook_ops structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged, thanks.

> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 33fd061..2f2e133 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -6530,7 +6530,7 @@ security_initcall(selinux_init);
>
>  #if defined(CONFIG_NETFILTER)
>
> -static struct nf_hook_ops selinux_nf_ops[] = {
> +static const struct nf_hook_ops selinux_nf_ops[] = {
>         {
>                 .hook =         selinux_ipv4_postroute,
>                 .pf =           NFPROTO_IPV4,
> --
> 2.7.4

-- 
paul moore
www.paul-moore.com