linux-kernel - Re: [PATCH] s390/zcrypt: make CPRBX const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <437dfa91-ab0b-985b-0356-69da99a43120@linux.vnet.ibm.com>
Date:   Mon, 28 Aug 2017 08:37:26 +0200
From:   Harald Freudenberger <freude@...ux.vnet.ibm.com>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        freude@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/zcrypt: make CPRBX const

On 08/25/2017 03:10 PM, Bhumika Goyal wrote:
> Make this const as it is only used in a copy operation.
>
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/s390/crypto/zcrypt_msgtype6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/zcrypt_msgtype6.c b/drivers/s390/crypto/zcrypt_msgtype6.c
> index 4fddb43..afd20ce 100644
> --- a/drivers/s390/crypto/zcrypt_msgtype6.c
> +++ b/drivers/s390/crypto/zcrypt_msgtype6.c
> @@ -140,7 +140,7 @@ struct function_and_rules_block {
>   *   + 0x000A 'MRP     ' (MCL3 'PK' or CEX2C 'PK')
>   * - VUD block
>   */
> -static struct CPRBX static_cprbx = {
> +static const struct CPRBX static_cprbx = {
>  	.cprb_len	=  0x00DC,
>  	.cprb_ver_id	=  0x02,
>  	.func_id	= {0x54, 0x32},
Applied. Will be available with the next merge.
Thanks and have a nice day.

Harald Freudenberger