linux-kernel - Re: [RFC v1] sched/fair: search a task from the tail of the queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170828084155.3mopma55cdikqqcc@hirez.programming.kicks-ass.net>
Date:   Mon, 28 Aug 2017 10:41:55 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Uladzislau Rezki (Sony)" <urezki@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>, Mike Galbraith <efault@....de>,
        Oleksiy Avramchenko <oleksiy.avramchenko@...ymobile.com>,
        Paul Turner <pjt@...gle.com>, Oleg Nesterov <oleg@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mike Galbraith <umgwanakikbuti@...il.com>,
        Kirill Tkhai <tkhai@...dex.ru>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Nicolas Pitre <nicolas.pitre@...aro.org>
Subject: Re: [RFC v1] sched/fair: search a task from the tail of the queue

On Fri, Aug 25, 2017 at 12:11:31AM +0200, Uladzislau Rezki (Sony) wrote:
> From: Uladzislau Rezki <urezki@...il.com>
> 
> As a first step this patch makes cfs_tasks list as MRU one.
> It means, that when a next task is picked to run on physical
> CPU it is moved to the front of the list.
> 
> Thefore, the cfs_tasks list is more or less sorted (except woken
> tasks) starting from recently given CPU time tasks toward tasks
> with max wait time in a run-queue, i.e. MRU list.
> 
> Second, as part of the load balance operation, this approach
> starts detach_tasks()/detach_one_task() from the tail of the
> queue instead of the head, giving some advantages:
> 
> - tends to pick a task with highest wait time;
> - tasks located in the tail are less likely cache-hot,
>   therefore the can_migrate_task() decision is higher.
> 
> hackbench illustrates slightly better performance. For example
> doing 1000 samples and 40 groups on i5-3320M CPU, it shows below
> figures:
> 
> default: 0.644 avg
> patched: 0.637 avg
> 
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@...il.com>
> ---
>  kernel/sched/fair.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index c77e4b1d51c0..cda281c6bb29 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -6357,7 +6357,7 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
>  	if (hrtick_enabled(rq))
>  		hrtick_start_fair(rq, p);
>  
> -	return p;
> +	goto done;
>  simple:
>  	cfs_rq = &rq->cfs;
>  #endif
> @@ -6378,6 +6378,14 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
>  	if (hrtick_enabled(rq))
>  		hrtick_start_fair(rq, p);
>  
> +done: __maybe_unused
> +	/*
> +	 * Move the next running task to the front of
> +	 * the list, so our cfs_tasks list becomes MRU
> +	 * one.
> +	 */
> +	list_move(&se->group_node, &rq->cfs_tasks);
> +
>  	return p;
>  
>  idle:

Could you also run something like:

$ taskset 1 perf bench sched pipe

to make sure the added list_move() doesn't hurt, I'm not sure group_node
and cfs_tasks are in cachelines we already touch for that operation.

And if you can see that list_move() hurt in "perf annotate", try moving
those members around to lines that we already need anyway.