linux-kernel - Re: [PATCH] tracing: make dynamic types can use __TRACE_LAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2017 07:01:46 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Zhou Chengming <zhouchengming1@...wei.com>
Cc:     <linux-kernel@...r.kernel.org>, <mingo@...hat.com>
Subject: Re: [PATCH] tracing: make dynamic types can use __TRACE_LAST_TYPE

On Mon, 28 Aug 2017 12:59:08 +0800
Zhou Chengming <zhouchengming1@...wei.com> wrote:

> Obviously, trace_events that defined staticly in trace.h won't use
> __TRACE_LAST_TYPE, so make dynamic types can use it. And some
> minor changes to trace_search_list() to make code clearer.

Is there some reason to do this? I'm not sure it makes the code any
clearer. It looks like churn for churn sake. Which means that it can
cause a bug, and requires a bit of work to verify it does not.

Now if there's other work that is being done that requires this change,
then I have no problem adding it. But if it is just to "make it
clearer" then no, I'm not adding it.

-- Steve

> 
> Signed-off-by: Zhou Chengming <zhouchengming1@...wei.com>