linux-kernel - Re: [PATCH] perf/ftrace: fix doubled traces of perf on ftrace:function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2017 13:07:06 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Zhou Chengming <zhouchengming1@...wei.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, acme@...nel.org,
        rostedt@...dmis.org, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, huawei.libin@...wei.com
Subject: Re: [PATCH] perf/ftrace: fix doubled traces of perf on
 ftrace:function

On Fri, Aug 25, 2017 at 09:49:37PM +0800, Zhou Chengming wrote:

SNIP

> diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
> index 562fa69..70c5025 100644
> --- a/kernel/trace/trace_event_perf.c
> +++ b/kernel/trace/trace_event_perf.c
> @@ -306,6 +306,7 @@ void perf_trace_buf_update(void *record, u16 type)
>  perf_ftrace_function_call(unsigned long ip, unsigned long parent_ip,
>  			  struct ftrace_ops *ops, struct pt_regs *pt_regs)
>  {
> +	struct perf_event *event;
>  	struct ftrace_entry *entry;
>  	struct hlist_head *head;
>  	struct pt_regs regs;
> @@ -329,8 +330,9 @@ void perf_trace_buf_update(void *record, u16 type)
>  
>  	entry->ip = ip;
>  	entry->parent_ip = parent_ip;
> +	event = container_of(ops, struct perf_event, ftrace_ops); 

nit, white space at the end of the line ^^^

but the change looks good to me

Reviewed-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka