linux-kernel - Re: [PATCH] mm/zswap: constify struct kernel_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALZtONCY64ck=FDriOR=m_RJnURto2rGP76mu-k5-g=c-My_yw@mail.gmail.com>
Date:   Mon, 28 Aug 2017 09:29:11 -0400
From:   Dan Streetman <ddstreet@...e.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Seth Jennings <sjenning@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH] mm/zswap: constify struct kernel_param_ops uses

On Sat, Aug 26, 2017 at 1:41 PM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> kernel_param_ops are not supposed to change at runtime. All functions
> working with kernel_param_ops provided by <linux/moduleparam.h> work
> with const kernel_param_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Dan Streetman <ddstreet@...e.org>

> ---
>  mm/zswap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index d39581a..030fbf9 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -82,7 +82,7 @@ static u64 zswap_duplicate_entry;
>  static bool zswap_enabled;
>  static int zswap_enabled_param_set(const char *,
>                                    const struct kernel_param *);
> -static struct kernel_param_ops zswap_enabled_param_ops = {
> +static const struct kernel_param_ops zswap_enabled_param_ops = {
>         .set =          zswap_enabled_param_set,
>         .get =          param_get_bool,
>  };
> @@ -93,7 +93,7 @@ module_param_cb(enabled, &zswap_enabled_param_ops, &zswap_enabled, 0644);
>  static char *zswap_compressor = ZSWAP_COMPRESSOR_DEFAULT;
>  static int zswap_compressor_param_set(const char *,
>                                       const struct kernel_param *);
> -static struct kernel_param_ops zswap_compressor_param_ops = {
> +static const struct kernel_param_ops zswap_compressor_param_ops = {
>         .set =          zswap_compressor_param_set,
>         .get =          param_get_charp,
>         .free =         param_free_charp,
> @@ -105,7 +105,7 @@ module_param_cb(compressor, &zswap_compressor_param_ops,
>  #define ZSWAP_ZPOOL_DEFAULT "zbud"
>  static char *zswap_zpool_type = ZSWAP_ZPOOL_DEFAULT;
>  static int zswap_zpool_param_set(const char *, const struct kernel_param *);
> -static struct kernel_param_ops zswap_zpool_param_ops = {
> +static const struct kernel_param_ops zswap_zpool_param_ops = {
>         .set =          zswap_zpool_param_set,
>         .get =          param_get_charp,
>         .free =         param_free_charp,
> --
> 2.7.4
>