linux-kernel - Re: [Xen-devel] [PATCH v8 10/13] x86/xen: Bypass intr mode setup in enlighten

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f5cc022-64cd-6738-5328-390ee2715c72@cn.fujitsu.com>
Date:   Mon, 28 Aug 2017 13:15:52 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Juergen Gross <jgross@...e.com>, <x86@...nel.org>,
        <linux-kernel@...r.kernel.org>, <tglx@...utronix.de>
CC:     <indou.takao@...fujitsu.com>, <bhe@...hat.com>,
        <izumi.taku@...fujitsu.com>, <rjw@...ysocki.net>, <bp@...en8.de>,
        <hpa@...or.com>, <xen-devel@...ts.xenproject.org>,
        <boris.ostrovsky@...cle.com>, <mingo@...nel.org>
Subject: Re: [Xen-devel] [PATCH v8 10/13] x86/xen: Bypass intr mode setup in
 enlighten_pv system

Hi Juergen,

At 08/28/2017 12:32 PM, Juergen Gross wrote:
> On 28/08/17 06:25, Juergen Gross wrote:
>> On 28/08/17 05:20, Dou Liyang wrote:
>>> XEN PV overrides smp_prepare_cpus(). xen_pv_smp_prepare_cpus()
>>> initializes interrupts in the XEN PV specific way and does not invoke
>>> native_smp_prepare_cpus(). As a consequence, x86_init.intr_mode_init() is
>>> not invoked either.
>>>
>>> The invocation of x86_init.intr_mode_init() will be moved from
>>> native_smp_prepare_cpus() in a follow up patch to solve <INSERT
>>> REASON/PROBLEM>.
>>
>> Can you be a little bit more precise here, please? :-)
>>
>>> That move would cause the invocation of x86_init.intr_mode_init() for XEN
>>> PV platforms. To prevent that, override the default x86_init.
>>> intr_mode_init() callback with a noop().
>>>
>>> [Rewrited by Thomas Gleixner <tglx@...utronix.de>]
>>>
>>> Signed-off-by: Dou Liyang <douly.fnst@...fujitsu.com>
>>> Cc: xen-devel@...ts.xenproject.org
>>> Cc: boris.ostrovsky@...cle.com
>>
>> On which tree does this apply? Would be nice to get a hint against which
>> source this can be reviewed.
>
> Aah, just found the rest of the series. In case a single patch of a
> series isn't stand alone it would be nice to receive at least the cover
> letter of the series in order to know what its all about.
>
Sorry to confuse you, It's my fault.

Thank you for your reply. I understood. will CC the cover letter to
linux-xen and linux-acpi.

Thanks,
	dou.

>
> Juergen
>
>
>