linux-kernel - Re: [PATCH] mm/hmm: fix build when HMM is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2017 16:33:07 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     jglisse@...hat.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/hmm: fix build when HMM is disabled

I have only now noticed this patch and it fixes allnoconfig failure
I saw earlier this day and tried to address by
http://lkml.kernel.org/r/20170828075931.GC17097@dhcp22.suse.cz

On Fri 25-08-17 20:21:49, jglisse@...hat.com wrote:
> From: Jérôme Glisse <jglisse@...hat.com>
> 
> Combinatorial Kconfig is painfull. Withi this patch all below combination
> build.
> 
> 1)
> 
> 2)
> CONFIG_HMM_MIRROR=y
> 
> 3)
> CONFIG_DEVICE_PRIVATE=y
> 
> 4)
> CONFIG_DEVICE_PUBLIC=y
> 
> 5)
> CONFIG_HMM_MIRROR=y
> CONFIG_DEVICE_PUBLIC=y
> 
> 6)
> CONFIG_HMM_MIRROR=y
> CONFIG_DEVICE_PRIVATE=y
> 
> 7)
> CONFIG_DEVICE_PRIVATE=y
> CONFIG_DEVICE_PUBLIC=y
> 
> 8)
> CONFIG_HMM_MIRROR=y
> CONFIG_DEVICE_PRIVATE=y
> CONFIG_DEVICE_PUBLIC=y
> 
> Signed-off-by: Jérôme Glisse <jglisse@...hat.com>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> ---
>  include/linux/hmm.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/linux/hmm.h b/include/linux/hmm.h
> index 9583d9a15f9c..96d6b1232c07 100644
> --- a/include/linux/hmm.h
> +++ b/include/linux/hmm.h
> @@ -498,7 +498,7 @@ struct hmm_device {
>  struct hmm_device *hmm_device_new(void *drvdata);
>  void hmm_device_put(struct hmm_device *hmm_device);
>  #endif /* CONFIG_DEVICE_PRIVATE || CONFIG_DEVICE_PUBLIC */
> -
> +#endif /* IS_ENABLED(CONFIG_HMM) */
>  
>  /* Below are for HMM internal use only! Not to be used by device driver! */
>  #if IS_ENABLED(CONFIG_HMM_MIRROR)
> @@ -513,6 +513,4 @@ static inline void hmm_mm_destroy(struct mm_struct *mm) {}
>  static inline void hmm_mm_init(struct mm_struct *mm) {}
>  #endif /* IS_ENABLED(CONFIG_HMM_MIRROR) */
>  
> -
> -#endif /* IS_ENABLED(CONFIG_HMM) */
>  #endif /* LINUX_HMM_H */
> -- 
> 2.13.4
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

-- 
Michal Hocko
SUSE Labs