linux-kernel - Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170828081624.16a1e4de@xeon-e3>
Date:   Mon, 28 Aug 2017 08:16:24 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Eduardo Otubo <otubo@...hat.com>
Cc:     linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip

On Mon, 28 Aug 2017 12:01:21 +0200
Eduardo Otubo <otubo@...hat.com> wrote:

> v2: The script is now a little bit safer so it doesn't conflicts with
> network daemon trying to set configurations at the same time.
> 
> This patch fixes the behavior of the hv_set_ifconfig script when setting
> the interface ip. Sometimes the interface has already been configured by
> network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> exists error"; in order to avoid this error this patch makes sure double
> checks the interface before trying anything.
> 
> Signed-off-by: Eduardo Otubo <otubo@...hat.com>

Adding new dependency on systemd is not going to make this script
even less useful.  I wonder why the script still exists at all? Most of the
Linux distro's can already setup HV networking without it.