linux-kernel - Re: [PATCH] Documentation: fix little inconsistencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170828161707.GA4750@magnolia>
Date:   Mon, 28 Aug 2017 09:17:07 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        tytso@....edu, corbet@....net, linux-ext4@...r.kernel.org,
        Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] Documentation: fix little inconsistencies

On Mon, Aug 28, 2017 at 11:46:39AM +0200, Pavel Machek wrote:
> Fix little inconsistencies in Documentation: make case and spacing
> match surrounding text, fix ascii-art.
> 
> Signed-off-by: Pavel Machek <pavel@....cz>
> 
> diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
> index 5a8f7f4..75236c0 100644
> --- a/Documentation/filesystems/ext4.txt
> +++ b/Documentation/filesystems/ext4.txt
> @@ -94,10 +94,10 @@ Note: More extensive information for getting started with ext4 can be
>  * ability to pack bitmaps and inode tables into larger virtual groups via the
>    flex_bg feature
>  * large file support
> -* Inode allocation using large virtual block groups via flex_bg
> +* inode allocation using large virtual block groups via flex_bg
>  * delayed allocation
>  * large block (up to pagesize) support
> -* efficient new ordered mode in JBD2 and ext4(avoid using buffer head to force
> +* efficient new ordered mode in JBD2 and ext4 (avoid using buffer head to force
>    the ordering)
>  
>  [1] Filesystems with a block size of 1k may see a limit imposed by the
> @@ -105,7 +105,7 @@ directory hash tree having a maximum depth of two.
>  
>  2.2 Candidate features for future inclusion
>  
> -* Online defrag (patches available but not well tested)
> +* online defrag (patches available but not well tested)
>  * reduced mke2fs time via lazy itable initialization in conjunction with
>    the uninit_bg feature (capability to do this is available in e2fsprogs
>    but a kernel thread to do lazy zeroing of unused inode table blocks
> @@ -602,7 +602,7 @@ Table of Ext4 specific ioctls
>  			      bitmaps and inode table, the userspace tool thus
>  			      just passes the new number of blocks.
>  
> -EXT4_IOC_SWAP_BOOT	      Swap i_blocks and associated attributes
> + EXT4_IOC_SWAP_BOOT	      Swap i_blocks and associated attributes
>  			      (like i_blocks, i_size, i_flags, ...) from
>  			      the specified inode with inode
>  			      EXT4_BOOT_LOADER_INO (#5). This is typically
> diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
> index 5e40e1f..6309e90 100644
> --- a/Documentation/networking/switchdev.txt
> +++ b/Documentation/networking/switchdev.txt
> @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
>                        sw1p1  +  sw1p3  +  sw1p5  +          eth1
>                          +    |    +    |    +    |            +
>                          |    |    |    |    |    |            |
> -                     +--+----+----+----+-+--+----+---+  +-----+-----+
> +                     +--+----+----+----+----+----+---+  +-----+-----+

Except for this last part, looks ok.

Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

>                       |         Switch driver         |  |    mgmt   |
>                       |        (this document)        |  |   driver  |
>                       |                               |  |           |
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html